Remove support for NS2x runtime tfms and rename package to Microsoft.DotNet.Build.Tasks.TargetFramework#8418
Merged
ViktorHofer merged 1 commit intomainfrom Feb 1, 2022
Merged
Conversation
dotnet/runtime was the only consumer that dependent on runtime specific .NETStandard tfms. Now that we are removing them with dotnet/runtime#64610 we can also delete the hacks to make them work in the TargetFramework package. Also renaming the project from Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk to Microsoft.DotNet.Build.Tasks.TargetFramework as doesn't need to be an msbuild sdk anymore and consuming it as a package will reduce evaluation time.
ViktorHofer
force-pushed
the
ViktorHofer-patch-1
branch
from
51831e5 to
9a17698
Compare
ViktorHofer
changed the title
Member
Author
safern
approved these changes
Feb 1, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4859
dotnet/runtime was the only consumer that dependent on runtime specific
.NETStandard tfms. Now that we are removing them with
dotnet/runtime#64610 we can also delete the
hacks to make them work in the TargetFramework package.
Also renaming the project from
Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk to
Microsoft.DotNet.Build.Tasks.TargetFramework as doesn't need to be an
msbuild sdk anymore and consuming it as a package will reduce evaluation
time.
I recommend to not merge this PR before dotnet/runtime#64610 isn't in.